forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #392
Merged
Merged
Merge upstream #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org)
Signed-off-by: Ben Berry <ben.berry@gsa.gov>
Signed-off-by: Ben Berry <ben.berry@gsa.gov>
Check sso whitelist in more places
…-notes 3.2.1 Version bump and release notes
- overcomes some weird change of permission type
… was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected
… into filemoves-permissions
# Conflicts: # package-lock.json
…issions Make permissions model extension friendly
Helm: Change default image pull policy to Always
…ole-log Fix errors in console log during setup screens
…y-icon Use Recent Activity icon that is less easily confused with Refresh
…filename-wrapping Fix for buildpack filename wrapping on card
…actions Add copy address and edit to endpoint table view
…ndry#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>
…y#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Fail Concourse CI build if imagelist generation fails
…plates/deployment.yaml
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 59.19% 59.62% +0.42%
==========================================
Files 1052 1057 +5
Lines 33119 33281 +162
Branches 4643 4671 +28
==========================================
+ Hits 19606 19843 +237
+ Misses 13513 13438 -75 |
richard-cox
commented
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
nwmac
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fix for .. Helm Chart: Icon is missing …