Fix issue where charts list errors if only helm hub registered #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
Sep 18, 2020
richard-cox
commented
- this was a regression
- we shouldn't make the call if there's no registered endpoints of that type anyway
richard-cox
changed the title
…are registered - this was a regression - we shouldn't make the call if there's no registered endpoints anyway
richard-cox
force-pushed
the
fix-helm-hub-only-chart-list
branch
from
6dcb0ef to
f6b4192
Compare
- apply flex to ensure form fields are correct width
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 57.83% 57.83%
=======================================
Files 1064 1064
Lines 34393 34393
Branches 4876 4876
=======================================
Hits 19892 19892
Misses 14501 14501 |
richard-cox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.