HTTP 401 responses should include WWW-Authentciate header #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating a HTTP 401 StatusUnauthorized response to a telemetry client the response should include an appropriate WWW-Authenticate header indicating to the client what action it should take to address it's lack of authorization. The generated WWW-Authenticate header uses a custom "Bearer" challenge specifying a realm of "suse-telemetry-service" with a scope of either "authenticate" or "register" indicating the appropriate action which the client needs to take. Fixes: #47
rtamalin
force-pushed
the
unauthorized_www_authenticate_header
branch
from
1280f59
to
b79fbb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a HTTP 401 StatusUnauthorized response to a telemetry client the response should include an appropriate WWW-Authenticate header indicating to the client what action it should take to address it's lack of authorization.
The generated WWW-Authenticate header uses a custom "Bearer" challenge specifying a realm of "suse-telemetry-service" with a scope of either "authenticate" or "register" indicating the appropriate action which the client needs to take.
Fixes: #47