Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate layers after new file is opened #993

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

VenissaCarolQuadros
Copy link
Contributor

PR description

With this fix the layers panel is updated when a new file is opened. Earlier, when an SVG file was opened the Layers panel was not populated with the correct number of layers and instead only showed 'Layer 1' irrespective of how many layers the newly opened file contained. This is fixed with a single-line change within the 'opensave' extension.

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

@VenissaCarolQuadros VenissaCarolQuadros marked this pull request as ready for review September 16, 2024 17:55
@VenissaCarolQuadros
Copy link
Contributor Author

Thanks for the quick review!
Just a reminder that this is still awaiting merge from someone with write access.

@jfhenon jfhenon merged commit 59690cd into SVG-Edit:master Sep 20, 2024
5 checks passed
@VenissaCarolQuadros VenissaCarolQuadros deleted the populate-layers-fix branch September 26, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants