Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge layer_view extension #995

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

VenissaCarolQuadros
Copy link
Contributor

PR description

Created a new extension called 'layer_view' extension in the TopPanel, which can easily make only the current layer visible. I find myself repeatedly doing but have to do this except it earlier required clicking the eye icon on each of the layers which gets tedious if there are many layers.

It has been designed as follows:

  1. When turned on the 'layerinvis' is included in the class list of all but the current layer
  2. The tool can be disabled either by clicking on the tool again or clicking on one of the 'eye' icons on the side. The latter is done to not disrupt the functionality of the LayerPanel.

I realize this is not a requested feature but thought it would be a neat feature to add. The default state in the ConfigObj.js is set to false but could be set to true id required.

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

@VenissaCarolQuadros VenissaCarolQuadros marked this pull request as ready for review September 27, 2024 01:40
Copy link
Collaborator

@jfhenon jfhenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image The button is not styled like others (white/orange). Could you fix this? The rest is good and thank you for the addition.

@jfhenon jfhenon merged commit 49dd041 into SVG-Edit:master Sep 27, 2024
5 checks passed
@VenissaCarolQuadros VenissaCarolQuadros deleted the layer-view-extension branch October 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants