Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify bins as bin size rather than number of bins #2

Closed
MatthieuSchaller opened this issue Sep 13, 2020 · 1 comment
Closed

Specify bins as bin size rather than number of bins #2

MatthieuSchaller opened this issue Sep 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@MatthieuSchaller
Copy link
Member

In the auto-plotter, the number of bins needs to be specified. Wouldn't it make more sense to provide the bin size instead? This then means the size of the bins does not change when the data range changes (e.g. when comparing box sizes).
@MatthieuSchaller MatthieuSchaller added the enhancement New feature or request label Sep 13, 2020
@JBorrow
Copy link
Member

JBorrow commented Sep 13, 2020

It's not clear this is a good idea to me; we would need to specify the bin width in log for log bins (without units) and in linear for linear binning with units...

@JBorrow JBorrow closed this as completed Dec 14, 2020
robjmcgibbon pushed a commit that referenced this issue Mar 6, 2024
@JBorrow
Merge pull request #2 from calvin-sykes/tomczak13-gsmf
b12cebe 
Add data and converter script for Tomczak et. al. (2013) GSMF
FHusko pushed a commit to FHusko/pipeline-configs-spin-jets that referenced this issue Mar 22, 2024
@FilipHusko
update submodule SWIFTSIM#2
425b46d
EvgeniiChaikin added a commit that referenced this issue Mar 24, 2024
@FHusko @FilipHusko @EvgeniiChaikin
Add binned stellar mass - BH mass plot (#275)
fef01bc 
* Add new stellar mass - BH mass plot

* Add new data to BH accretion evolution plot

* Run formatting

* Remove duplicate line

* Correct directory name for binned BH mass data

Co-authored-by: Evgenii Chaikin <bowowoda@gmail.com>

* update submodule

* update submodule #2

* update submodule #3

---------

Co-authored-by: Filip Husko <filip.husko@durham.ac.uk>
Co-authored-by: Evgenii Chaikin <bowowoda@gmail.com>
robjmcgibbon pushed a commit that referenced this issue May 23, 2024
@FHusko @FilipHusko @EvgeniiChaikin
Add new high-z BH mass - stellar mass data, as well as updated BH mas…
686a005 
…s function data (#282)

* Add new stellar mass - BH mass plot

* Add new data to BH accretion evolution plot

* Run formatting

* Remove duplicate line

* Correct directory name for binned BH mass data

Co-authored-by: Evgenii Chaikin <bowowoda@gmail.com>

* update submodule

* update submodule #2

* update submodule #3

* Add high-redshift data for BH-stellar mass relation

* Add new BH mass function data

* Update submodule

---------

Co-authored-by: Filip Husko <filip.husko@durham.ac.uk>
Co-authored-by: Evgenii Chaikin <bowowoda@gmail.com>
Co-authored-by: Filip Husko <dc-husk1@login7b.pri.cosma7.alces.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JBorrow @MatthieuSchaller