Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN or Inf values in cold gas fractions plots #95

Open
EvgeniiChaikin opened this issue Feb 15, 2021 · 1 comment
Open

NaN or Inf values in cold gas fractions plots #95

EvgeniiChaikin opened this issue Feb 15, 2021 · 1 comment

Comments

@EvgeniiChaikin
Copy link
Collaborator

The data in several cold-gas-fractions plots may have NaN values (depending on the run and redshift), which makes the pipeline crash in certain cases.

E.g. sigma_h2_to_neutral_H_fraction_100

Possible solution: always use mask whenever there is a change to have division by zero.

@JBorrow
Copy link
Member

JBorrow commented Feb 15, 2021

Yes, I've been concerned about this previously.

We do not want to just mask when there is a division by zero. That's the wrong thing to do here. There will be a physical reason that there is no HI, and in the real universe we wouldn't be able to measure the HI in those galaxies - so we should cut by that physical reason (e.g. just plot for star forming galaxies in a given mass range).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants