Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment display is incorrect when navigating while Edit mode is active. #705

Closed
ghost opened this issue Apr 30, 2020 · 0 comments · Fixed by #711
Closed

Comment display is incorrect when navigating while Edit mode is active. #705

ghost opened this issue Apr 30, 2020 · 0 comments · Fixed by #711
Labels

Comments

@ghost
Copy link

ghost commented Apr 30, 2020

To reproduce:

  1. Create a new game
  2. Go to "Manage Games" and add another game
  3. In the second game, go to the Edit mode. Add any comment.
  4. With edit mode still active, use the "Go to Previous Game" keyboard shortcut (CtrlOrCmd-PageDown) to go to the other game.

The comment is still shown and if you exit Edit mode now the first game gets that comment as well even though it shouldn't.

This also happens when you have a single game and add a few moves. Then, for any move, go to Edit mode and add a comment. Don't leave the Edit mode but select any tool, like the triangle tool. Then use arrow keys to go to other moves. The comment is still visible even though it shouldn't be.

@yishn yishn added the bug label May 1, 2020
@yishn yishn closed this as completed in #711 May 6, 2020
yishn pushed a commit that referenced this issue May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant