Detach all engines when the window closed #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yishn
reviewed
Apr 20, 2020
src/components/App.js
Outdated
| gtplogger.close() | ||
| this.closeWindow = true | ||
| sabaki.window.close() | ||
| await promise |
There was a problem hiding this comment.
In this case, I don't think we even need to await the promise.
There was a problem hiding this comment.
Oh, that's right. Thanks!
yishn
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the engine over SSH may leave the engine's processes on the remote computer. This PR prevents it.
Also, if await sabaki.detachEngines() is done before sabaki.window.close(), it may take a long time to close the window, so await is at the end.