Keep healtcheck port flag backward compatibility (jaegertracing#1315)

cmd/flags/flags.go

@@ -33,6 +33,7 @@ const (
 	logLevel              = "log-level"
 	configFile            = "config-file"
 	adminEndpointHTTPPort = "admin-endpoint-http-port"
+	healthCheckHTTPPort   = "health-check-http-port" // deprecated
 )
 
 var defaultAdminEdpointPort int
@@ -79,6 +80,7 @@ func SetDefaultAdminEndpointPort(port int) {
 func AddFlags(flagSet *flag.FlagSet) {
 	flagSet.String(spanStorageType, "", fmt.Sprintf(`Deprecated; please use %s environment variable. Run this binary with "env" command for help.`, storage.SpanStorageTypeEnvVar))
 	flagSet.Int(adminEndpointHTTPPort, defaultAdminEdpointPort, "The http port for the health check service")
+	flagSet.Int(healthCheckHTTPPort, defaultAdminEdpointPort, fmt.Sprintf("Deprecated; please use %s", adminEndpointHTTPPort))
 	AddLoggingFlag(flagSet)
 }
 
@@ -91,6 +93,9 @@ func AddLoggingFlag(flagSet *flag.FlagSet) {
 func (flags *SharedFlags) InitFromViper(v *viper.Viper) *SharedFlags {
 	flags.Logging.Level = v.GetString(logLevel)
 	flags.AdminEndpoint.Port = v.GetInt(adminEndpointHTTPPort)
+	if flags.AdminEndpoint.Port == defaultAdminEdpointPort {
+		flags.AdminEndpoint.Port = v.GetInt(healthCheckHTTPPort)
+	}
 	return flags
 }