Cleanup von #433, #434 und #436 #441

GideonKoenig · 2022-04-22T09:39:33Z

Enternen der Kommentare und Script Teile in der Combine Funktion und es sollten die tatsächlichen Funktionen aufgerufen werden
Struktur der Einsammelfunktion der Diciontaries
Einbettung der drei Funktionen in ein gemeinesames Modul
Die einzelnen Generate Funktion sollten die selben Paramter verwenden (api und usages)
Die Funktionen sollten nicht alle einzeln nacheinander aufgerufen werden, sondern im bulk
Der Test für die constant Annotations muss angepasst werden
None muss abgefange werden in der Funktion __determinte_constant_paramters (Zeile 145) (einfach Gideon ansprechen)

* Reformatting and Cleanup for #441 * Changed callable to Typing.Callable * style: apply automatic fixes of linters * Ausbauen und fixen von Tests; Unused betrachtet Parameter, Klassen und Funktionen; Preprocess Usages in tests für einzelne annotations hinzugefügt; kombinieren von usage_datas und api_datas; anpassen von readme und cli.py * style: apply automatic fixes of linters * fixed imports * style: apply automatic fixes of linters * Changed outfile from TextIOWrapper to Path * fixed imports again * style: apply automatic fixes of linters Co-authored-by: jofaul <jofaul@users.noreply.github.com>

* Code should be working - Still need to write a test * Add tests and prepare for merge with issue #441 * Still testing * get required test funktioniert jetzt * Test done and working * Satisfy Linter * style: apply automatic fixes of linters * Bug fix * Implemented the new AnnotationStore object Improved auxiliary functions Added ParameterInfo Class to communicate the return values of functions better Migrated said ParameterInfo and ParameterType classes to annotation_model.py Test is now working - all is good * Update package-parser.iml * Renamed function to better communicate it's function * Delete package-parser.iml * Satisfy Linter -> Fixed typing * style: apply automatic fixes of linters * Remove unnecessary import * Further seperate the replaceable math part of determining if a parameter should be optional or required for more clarity * Function namechange Co-authored-by: GideonKoenig <ginosiassa.koenig@online.de> Co-authored-by: GideonKoenig <GideonKoenig@users.noreply.github.com>

* Code should be working - Still need to write a test * feat: Added function for getting optional annotations and added tests * feat: Adjusted tests and function which calculates if a parameter is optional or required * Add tests and prepare for merge with issue #441 * Still testing * get required test funktioniert jetzt * Test done and working * Satisfy Linter * style: apply automatic fixes of linters * Bug fix * Implemented the new AnnotationStore object Improved auxiliary functions Added ParameterInfo Class to communicate the return values of functions better Migrated said ParameterInfo and ParameterType classes to annotation_model.py Test is now working - all is good * Update package-parser.iml * Renamed function to better communicate it's function * Delete package-parser.iml * Satisfy Linter -> Fixed typing * style: apply automatic fixes of linters * Remove unnecessary import * Further seperate the replaceable math part of determining if a parameter should be optional or required for more clarity * Function namechange * feat: Adjusted tests and functions for optional annotation & removed unused test files * feat: Fixed optional annotation function and adjusted them according to the new data class structure and adjusted the optional annotation test. * style: apply automatic fixes of linters * style: apply automatic fixes of linters * refactor: changed variable naming and comments Co-authored-by: GideonKoenig <ginosiassa.koenig@online.de> Co-authored-by: GideonKoenig <GideonKoenig@users.noreply.github.com> Co-authored-by: GideonKoenig <44088734+GideonKoenig@users.noreply.github.com> Co-authored-by: Masara <Masara@users.noreply.github.com> Co-authored-by: Lars Reimann <mail@larsreimann.com>

GideonKoenig added the cleanup 🧹 Refactorings and other tasks that improve the code label Apr 22, 2022

GideonKoenig changed the title ~~Saubere Integration von #433, #434 und~~ Cleanup von #433, #434 und #436 Apr 22, 2022

GideonKoenig added this to API Editor Apr 22, 2022

GideonKoenig moved this to Backlog in API Editor Apr 22, 2022

GideonKoenig moved this from Backlog to Todo in API Editor Apr 22, 2022

GideonKoenig assigned jofaul Apr 22, 2022

Masara moved this from Todo to In Progress in API Editor Apr 22, 2022

jofaul added a commit that referenced this issue Apr 22, 2022

Reformatting and Cleanup for #441

7ef5be1

jofaul mentioned this issue Apr 22, 2022

refactor: Reformatting and Cleanup for #441 #446

Merged

Masara closed this as completed in #446 Apr 29, 2022

Repository owner moved this from In Progress to ✔️ Done in API Editor Apr 29, 2022

GideonKoenig pushed a commit that referenced this issue Apr 29, 2022

Add tests and prepare for merge with issue #441

784d447

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cleanup von #433, #434 und #436 #441

Cleanup von #433, #434 und #436 #441

GideonKoenig commented Apr 22, 2022 •

edited by jofaul

Loading

Cleanup von #433, #434 und #436 #441

Cleanup von #433, #434 und #436 #441

Comments

GideonKoenig commented Apr 22, 2022 • edited by jofaul Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GideonKoenig commented Apr 22, 2022 •

edited by jofaul

Loading