Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor implementation todos #381

Closed
4 tasks done
lars-reimann opened this issue Jan 27, 2023 · 2 comments
Closed
4 tasks done

Minor implementation todos #381

lars-reimann opened this issue Jan 27, 2023 · 2 comments

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Jan 27, 2023 •
edited by Gerhardsa0
Loading

Is your feature request related to a problem? Please describe
@github-project-automation github-project-automation bot moved this to Backlog in Safe-DS Jan 27, 2023
@SmiteDeluxe SmiteDeluxe mentioned this issue Jan 29, 2023
Merged
@SmiteDeluxe
Copy link
Contributor

Think the legend range is always -1 to 1, since we map correlations in %, so made no change to this particularly, only color scheme.

SmiteDeluxe added a commit that referenced this issue Jan 31, 2023
@SmiteDeluxe
fix: Minor fixes for visualization tutorial, summary & heatmap (#391)
4926613 
### Summary of Changes

Fixed the visualization tutorial with discussed changes from #380 as
well as 3 of the bullet points from #381 (namely summary header, summary
all string and heatmap color scheme).

---------

Co-authored-by: SmiteDeluxe <SmiteDeluxe@users.noreply.github.com>
@SmiteDeluxe SmiteDeluxe moved this from Backlog to ✔️ Done in Safe-DS Feb 1, 2023
@lars-reimann
Copy link
Member Author

Closing this since all items are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lars-reimann @SmiteDeluxe