-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom editor / visualizer to vscode extension #1243
base: main
Are you sure you want to change the base?
Conversation
… statement node expandable
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ CSS | stylelint | 3 | 0 | 0 | 1.6s |
✅ JAVASCRIPT | eslint | 4 | 0 | 0 | 3.45s |
prettier | 4 | 0 | 1 | 0.6s | |
✅ JSON | jsonlint | 10 | 0 | 0.25s | |
✅ JSON | npm-package-json-lint | yes | no | 0.84s | |
prettier | 79 | 0 | 1 | 1.55s | |
✅ JSON | v8r | 10 | 0 | 16.01s | |
✅ MARKDOWN | markdown-link-check | 1 | 0 | 0.7s | |
✅ REPOSITORY | git_diff | yes | no | 0.39s | |
✅ TSX | eslint | 66 | 0 | 0 | 15.02s |
✅ TYPESCRIPT | eslint | 42 | 0 | 0 | 11.09s |
prettier | 42 | 0 | 1 | 0.5s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true
in mega-linter.yml to validate all sources, not only the diff
@GideonKoenig Please start by fixing the failing checks (builds, lint, PR title). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments about the stub changes.
*/ | ||
DataExport | ||
DataProcessingQColumn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the "Q" stand for? Just some separator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Special Characters are not allowed, so I decided to use 'Q' as a Separator.
*/ | ||
DataPreparation | ||
DataExport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about data import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data import is defined in row 36.
/**
* Load your data into the program.
*/
DataImport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a separate PR that includes the changes to the stubs. That would be a start to disentangle this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new PR that extracts the changes made to the stubs has been created: #1263.
class TablePlotter(table: Table) { | ||
/** | ||
* Create a box plot for every numerical column. | ||
* | ||
* @param theme The color theme of the plot. Default is "light". | ||
* | ||
* @result plot The box plot(s) as an image. | ||
* | ||
* @example | ||
* pipeline example { | ||
* val table = Table({"a":[1, 2], "b": [3, 42]}); | ||
* val image = table.plot.boxPlots(); | ||
* } | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the formatting of the remaining stub code the same. The stubs are generated mostly automatically, and we use Git patches/diffs to apply updates. Formatting changes lead to unnecessary conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reformatting was not intentional. The PR with the extracted changes specifically to the Stubs fixes this.
Giant Pull Request - All in one - I'm sorry