Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom editor / visualizer to vscode extension #1243

Open
wants to merge 78 commits into
base: main
Choose a base branch
from

Conversation

GideonKoenig
Copy link
Contributor

Giant Pull Request - All in one - I'm sorry

GideonKoenigJukabo and others added 30 commits January 27, 2024 14:08
@GideonKoenig GideonKoenig added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 3 0 0 1.6s
✅ JAVASCRIPT eslint 4 0 0 3.45s
⚠️ JAVASCRIPT prettier 4 0 1 0.6s
✅ JSON jsonlint 10 0 0.25s
✅ JSON npm-package-json-lint yes no 0.84s
⚠️ JSON prettier 79 0 1 1.55s
✅ JSON v8r 10 0 16.01s
✅ MARKDOWN markdown-link-check 1 0 0.7s
✅ REPOSITORY git_diff yes no 0.39s
✅ TSX eslint 66 0 0 15.02s
✅ TYPESCRIPT eslint 42 0 0 11.09s
⚠️ TYPESCRIPT prettier 42 0 1 0.5s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann
Copy link
Member

@GideonKoenig Please start by fixing the failing checks (builds, lint, PR title).

@GideonKoenig GideonKoenig changed the title Custom editor / Visualization feat: add custom editor / visualization to vscode extension Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 31.32530% with 1026 lines in your changes missing coverage. Please review.

Project coverage is 94.86%. Comparing base (3d9d4db) to head (cafa613).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lang/src/language/custom-editor/ast-parser/call.ts 15.18% 268 Missing ⚠️
...src/language/custom-editor/ast-parser/statement.ts 22.31% 94 Missing ⚠️
.../src/language/custom-editor/getGlobalReferences.ts 18.69% 87 Missing ⚠️
...ang/src/language/custom-editor/ast-parser/utils.ts 33.33% 86 Missing ⚠️
...-lang/src/language/custom-editor/getSyncChannel.ts 26.66% 66 Missing ⚠️
...g/src/language/custom-editor/getNodeDescription.ts 21.95% 64 Missing ⚠️
...uage/custom-editor/ast-parser/tools/debug-utils.ts 22.36% 59 Missing ⚠️
...lang/src/language/custom-editor/ast-parser/main.ts 25.45% 41 Missing ⚠️
...lang/src/language/custom-editor/ast-parser/edge.ts 42.85% 40 Missing ⚠️
...rc/language/custom-editor/ast-parser/expression.ts 35.00% 39 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   99.79%   94.86%   -4.94%     
==========================================
  Files         110      128      +18     
  Lines       19247    20741    +1494     
  Branches     4110     4111       +1     
==========================================
+ Hits        19207    19675     +468     
- Misses         40     1066    +1026     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GideonKoenig GideonKoenig changed the title feat: add custom editor / visualization to vscode extension feat: add custom editor / visualizer to vscode extension Oct 29, 2024
@GideonKoenig GideonKoenig marked this pull request as ready for review October 29, 2024 14:28
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments about the stub changes.

*/
DataExport
DataProcessingQColumn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the "Q" stand for? Just some separator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Special Characters are not allowed, so I decided to use 'Q' as a Separator.

*/
DataPreparation
DataExport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about data import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data import is defined in row 36.

    /**
     * Load your data into the program.
     */
    DataImport

Copy link
Member

@lars-reimann lars-reimann Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR that includes the changes to the stubs. That would be a start to disentangle this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new PR that extracts the changes made to the stubs has been created: #1263.

Comment on lines +18 to +31
class TablePlotter(table: Table) {
/**
* Create a box plot for every numerical column.
*
* @param theme The color theme of the plot. Default is "light".
*
* @result plot The box plot(s) as an image.
*
* @example
* pipeline example {
* val table = Table({"a":[1, 2], "b": [3, 42]});
* val image = table.plot.boxPlots();
* }
*/
Copy link
Member

@lars-reimann lars-reimann Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the formatting of the remaining stub code the same. The stubs are generated mostly automatically, and we use Git patches/diffs to apply updates. Formatting changes lead to unnecessary conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformatting was not intentional. The PR with the extracted changes specifically to the Stubs fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

4 participants