Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove behavior protocol syntax #518

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

lars-reimann
Copy link
Member

Summary of Changes

  • Remove the syntax for behavior protocols
  • We can add this (and the actual validation) again once we have more use cases for behavior protocols. For now they only seem to be useful to ensure that predict/transform can only be used on fitted models/transformers.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #518 (ac606c1) into main (0b4a121) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files           5        5           
  Lines         173      173           
  Branches        3        3           
=======================================
  Hits          169      169           
  Misses          1        1           
  Partials        3        3           
Components Coverage Δ
dsl 97.50% <ø> (ø)
runner 100.00% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.02s
✅ YAML prettier 1 0 0 0.42s
✅ YAML v8r 1 0 4.37s
✅ YAML yamllint 1 0 0.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann force-pushed the remove_behavior_protocol_syntax branch from 82f6b5e to ac606c1 Compare June 30, 2023 08:52
@lars-reimann lars-reimann merged commit 72d3fcd into main Jun 30, 2023
@lars-reimann lars-reimann deleted the remove_behavior_protocol_syntax branch June 30, 2023 08:54
@lars-reimann lars-reimann mentioned this pull request Aug 4, 2023
7 tasks
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant