Table.remove_columns(): Specify what happens when removing the last column, so the table gets empty #276
Assignees
Labels
documentation 📖
Improvements or additions to documentation
enhancement 💡
New feature or request
question
Further information is requested
released
Included in a release
Comments
zzril
added
documentation 📖
|
Might be related to #123. In general, an empty table should have row count 0, but some methods might not be able to work properly with an empty table yet. Example: It should be possible to add any column to an empty table. |
alex-senger
added a commit
that referenced
this issue
Jun 23, 2023
…e last column (#384) Closes #276 ### Summary of Changes When removing the only column in a 1-column-table, the number_of_rows property is set to 0. This behaviour should be documented in the Table class docstring as well as in the following methods: Table.keep_only_columns, Table.remove_columns, Table.remove_columns_with_missing_values and Table.remove_columns_with_non_numerical_values. <!-- Please provide a summary of changes in this pull request, ensuring all changes are explained. --> --------- Co-authored-by: patrikguempel <128832338+patrikguempel@users.noreply.github.com>
|
🎉 This issue has been resolved in version 0.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
When removing the only column in a 1-column-table, the
number_of_rowsproperty is set to 0. This behaviour should be documented in theTableclass docstring as well as in the following methods:Table.keep_only_columns,Table.remove_columns,Table.remove_columns_with_missing_valuesandTable.remove_columns_with_non_numerical_values.Desired solution
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response
The text was updated successfully, but these errors were encountered: