Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added test for Table.remove_rows_with_outliers to test multiple outliers in one column and outliers in two different columns #309

Merged

Conversation

Marsmaennchen221
Copy link
Contributor

@Marsmaennchen221 Marsmaennchen221 commented May 19, 2023

Summary of Changes

test: Added test for Table.remove_rows_with_outliers to test multiple outliers in one column and outliers in two different columns

See my Comment in the referenced issue for further explanation as there is no bug with the current method Table.remove_rows_with_outliers

Additional Context

See #274

…le outliers in one column and outliers in two different columns
…be named `test_should_remove_rows_with_outliers`
@lars-reimann
Copy link
Member

lars-reimann commented May 19, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.5s
✅ PYTHON mypy 1 0 1.57s
✅ PYTHON ruff 1 0 0 0.02s
✅ REPOSITORY git_diff yes no 0.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Marsmaennchen221
Copy link
Contributor Author

Marsmaennchen221 commented May 26, 2023

Waiting for #123 for the improved Table.__eq__ method for the comparison of the empty tables.

…est-cant-detect-2-or-more-outliers-in-a-function

# Conflicts:
#	tests/safeds/data/tabular/containers/_table/test_remove_rows_with_outliers.py
@Marsmaennchen221 Marsmaennchen221 marked this pull request as ready for review June 9, 2023 08:23
@Marsmaennchen221 Marsmaennchen221 requested a review from a team as a code owner June 9, 2023 08:23
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #309 (130cbb3) into main (1326f40) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #309   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2162      2162           
=========================================
  Hits          2162      2162           

Copy link
Contributor

@alex-senger alex-senger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marsmaennchen221 Marsmaennchen221 requested a review from jxnior01 June 9, 2023 13:52
@jxnior01 jxnior01 merged commit d75ae96 into main Jun 12, 2023
@jxnior01 jxnior01 deleted the 274-pytest-cant-detect-2-or-more-outliers-in-a-function branch June 12, 2023 11:27
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants