feat: don't override when method could throw #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzril
changed the title
…-a-table' into 58b-don-t-override-when-throwing
…-a-table' into 58b-don-t-override-when-throwing
|
Will not implement this, instead change the parent method's signature/docstring to throw the exception. See this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: This PR is not to be merged into main, but into a feature branch.)
In
TaggedTable, don't override those method ofTablethat could potentially remove the target column.Instead, introduce new methods that specifically promise to maintain tagging, and throw an exception otherwise.
See also this comment in the original PR.