Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make multi-processing in baseline models more consistent #909

Merged

Conversation

sibre28
Copy link
Contributor

@sibre28 sibre28 commented Jul 12, 2024

Closes #907

Set Context of ProcesspoolExecutors to spawn

Copy link
Contributor

github-actions bot commented Jul 12, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 1.07s
✅ PYTHON mypy 2 0 3.01s
✅ PYTHON ruff 2 0 0 0.4s
✅ REPOSITORY git_diff yes no 0.67s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (d3f81dc) to head (7e40c7b).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         122      122           
  Lines        6592     6594    +2     
=======================================
+ Hits         6445     6447    +2     
  Misses        147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sibre28 and others added 5 commits July 12, 2024 16:45
…eline-models-break-sometimes' into 907-multiprocessing-tests-of-baseline-models-break-sometimes
Co-authored-by: Lars Reimann <mail@larsreimann.com>
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't fix the issue with polars 1.0.0, unfortunately, but still a needed change.

@lars-reimann lars-reimann merged commit fa24560 into main Jul 12, 2024
10 checks passed
@lars-reimann lars-reimann deleted the 907-multiprocessing-tests-of-baseline-models-break-sometimes branch July 12, 2024 18:57
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiprocessing Tests of Baseline Models break sometimes
3 participants