Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace the docstring_parser library with Griffe #79

Merged
merged 61 commits into from
Apr 7, 2024

Conversation

Masara
Copy link
Contributor

@Masara Masara commented Mar 27, 2024

Summary of Changes

Slowly removing the docstring_parser library and replacing it with Griffe.

Masara and others added 30 commits March 13, 2024 20:59
…er-with-griffe

# Conflicts:
#	tests/safeds_stubgen/docstring_parsing/test_numpydoc_parser.py
#	tests/safeds_stubgen/stubs_generator/__snapshots__/test_generate_stubs/test_stub_docstring_creation[numpydoc-NUMPYDOC].sdsstub
# Conflicts:
#	tests/safeds_stubgen/docstring_parsing/test_numpydoc_parser.py
#	tests/safeds_stubgen/stubs_generator/__snapshots__/test_generate_stubs/test_stub_docstring_creation[numpydoc-NUMPYDOC].sdsstub
@Masara Masara force-pushed the replace-docstring_parser-with-griffe branch from 2f77cd3 to 28ac483 Compare April 4, 2024 11:43
@Masara Masara force-pushed the replace-docstring_parser-with-griffe branch from 4b25e4c to 386a9f9 Compare April 4, 2024 13:51
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (8ea5a43) to head (dbf1616).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   99.26%   99.27%           
=======================================
  Files          24       22    -2     
  Lines        2185     2196   +11     
=======================================
+ Hits         2169     2180   +11     
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Masara Masara force-pushed the replace-docstring_parser-with-griffe branch from 161d9ca to dbf1616 Compare April 4, 2024 22:39
@Masara Masara marked this pull request as ready for review April 5, 2024 11:41
@Masara Masara requested review from a team and lars-reimann as code owners April 5, 2024 11:41
@Masara Masara assigned Masara and lars-reimann and unassigned Masara Apr 5, 2024
@Masara
Copy link
Contributor Author

Masara commented Apr 5, 2024

@lars-reimann This is ready for review

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lars-reimann lars-reimann merged commit 9b2f802 into main Apr 7, 2024
6 checks passed
@lars-reimann lars-reimann deleted the replace-docstring_parser-with-griffe branch April 7, 2024 08:23
lars-reimann pushed a commit that referenced this pull request May 4, 2024
## [0.3.0](v0.2.0...v0.3.0) (2024-05-04)

### Features

* Added handling for sequence classes ([#127](#127)) ([cb061ab](cb061ab)), closes [#126](#126)
* DocString result names for Safe-DS stub results ([#101](#101)) ([fe163e3](fe163e3)), closes [#100](#100)
* Examples from docstrings are also taken over to stub docstrings ([#116](#116)) ([6665186](6665186)), closes [#115](#115)
* Replace the docstring_parser library with Griffe ([#79](#79)) ([9b2f802](9b2f802))

### Bug Fixes

* `Self` types as results are translated to class names  ([#110](#110)) ([4554a56](4554a56)), closes [#86](#86)
* Creating stubs with relative paths for source and output directories ([#128](#128)) ([b4493c9](b4493c9)), closes [#125](#125)
* Docstrings have the correct indentation for nested classes (stubs) ([#114](#114)) ([c7b8550](c7b8550)), closes [#113](#113)
* Fixed a bug where double ? would be generated for stubs ([#103](#103)) ([c35c6ac](c35c6ac)), closes [#87](#87) [#87](#87)
* Fixed a bug where imports would not check reexports for shortest path ([#112](#112)) ([48c5367](48c5367)), closes [#82](#82)
* Fixed a bug where results in stubs would not be named ([#131](#131)) ([4408c84](4408c84)), closes [#100](#100)
* Fixed a bug which prevented mypy version update ([#107](#107)) ([501d2cd](501d2cd))
* Fixed the stubs generator ([#108](#108)) ([9ad6df6](9ad6df6)), closes [#80](#80)
* Generated names of callback results start with result, not with param ([#104](#104)) ([6e696e9](6e696e9)), closes [#85](#85)
* Include lines of examples that start with `...` ([#130](#130)) ([3477b4a](3477b4a)), closes [#129](#129)
* No "// TODO ..." if return type is explicitly `None` ([#111](#111)) ([08e345f](08e345f)), closes [#83](#83)
* Removed the Epydoc parser ([#89](#89)) ([684a101](684a101))
* Replaced tabs with 4 spaces ([#105](#105)) ([8e7aa5d](8e7aa5d)), closes [#84](#84)
* The file structure of stubs resembles the "package" path. ([#106](#106)) ([ff1800e](ff1800e)), closes [#81](#81)
* Translation of callable ([#102](#102)) ([c581e6a](c581e6a)), closes [#88](#88) [#88](#88)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants