Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-concept desktop keyboard navigation #278

Merged
merged 20 commits into from
May 3, 2022

Conversation

yolpsoftware
Copy link
Contributor

These changes allow the user to navigate through the browser using Tab and Shift-Tab.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #278 (dbecaff) into master (a4d1904) will decrease coverage by 0.32%.
The diff coverage is 9.75%.

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   58.91%   58.59%   -0.33%     
==========================================
  Files         271      272       +1     
  Lines       12176    12257      +81     
  Branches     1262     1274      +12     
==========================================
+ Hits         7174     7182       +8     
- Misses       4716     4786      +70     
- Partials      286      289       +3     
Impacted Files Coverage Δ
SafeExamBrowser.Browser/BrowserApplication.cs 0.00% <0.00%> (ø)
SafeExamBrowser.Browser/BrowserControl.cs 0.00% <0.00%> (ø)
SafeExamBrowser.Browser/BrowserWindow.cs 0.00% <0.00%> (ø)
...terface.Contracts/Browser/Data/JavascriptResult.cs 0.00% <0.00%> (ø)
SafeExamBrowser.Client/ClientController.cs 93.55% <33.33%> (-0.94%) ⬇️
...afeExamBrowser.Browser/Handlers/KeyboardHandler.cs 69.38% <35.71%> (-13.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d1904...dbecaff. Read the comment docs.

@dbuechel dbuechel self-assigned this May 2, 2022
@dbuechel dbuechel added this to the 3.4.0 milestone May 2, 2022
Copy link
Member

@dbuechel dbuechel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot @yolpsoftware! There unfortunately were some changes which are causing merge conflicts, so it'd be great if you could resolve these. Furthermore, if you'd have the time then it would be awesome if you could also translate all the new text into the other three languages (using Google Translate).

@yolpsoftware yolpsoftware requested a review from dbuechel May 2, 2022 15:11
@dbuechel
Copy link
Member

dbuechel commented May 2, 2022

Thanks a lot for the quick fixes @yolpsoftware. There are only 3 minor things left, once resolved I'll immediately approve and merge the pull request. Great work indeed 👍

@yolpsoftware
Copy link
Contributor Author

Had to adapt some code to the changes introduced by 7142380#diff-86bb6b5aa3ce5d57bf4a50c8682d6b4dbb47f45b4b69499e758ea166d571093e.

Copy link
Member

@dbuechel dbuechel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for the quick fixes. Looks all good to me now 👍

@dbuechel dbuechel merged commit 043187f into SafeExamBrowser:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants