Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRES-508: Fix streaming interceptor #170

Merged
merged 2 commits into from
Nov 6, 2023
Merged

IRES-508: Fix streaming interceptor #170

merged 2 commits into from
Nov 6, 2023

Conversation

matt-lewandowski
Copy link
Contributor

Changes

  1. Updates the connect-web-interceptor script to handle streaming requests.
  2. Switch to a try catch to match the await needed by the message generator.

Connect has documentation on how to properly setup a streaming interceptor. This implements that interceptor and ensures it is working. It looks like streaming was not previously working at all.
https://connectrpc.com/docs/web/interceptors/

Screenshot 2023-11-06 at 1 18 02 pm

Previously

Screen.Recording.2023-11-06.at.10.52.37.am.mov

@georgechieng-sc georgechieng-sc merged commit 3faf870 into master Nov 6, 2023
2 checks passed
@treelite treelite deleted the IRES-508 branch July 22, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants