Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVP-3487 use latest protoc-go #159

Merged
merged 14 commits into from
Sep 16, 2024
Merged

DEVP-3487 use latest protoc-go #159

merged 14 commits into from
Sep 16, 2024

Conversation

MickStanciu
Copy link
Contributor

@MickStanciu MickStanciu commented Sep 13, 2024

Summary

full rollback

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@MickStanciu MickStanciu marked this pull request as ready for review September 16, 2024 00:44
@MickStanciu MickStanciu requested a review from a team as a code owner September 16, 2024 00:44
HarryTranAU
HarryTranAU previously approved these changes Sep 16, 2024
HarryTranAU
HarryTranAU previously approved these changes Sep 16, 2024
@MickStanciu MickStanciu merged commit 20b3da0 into main Sep 16, 2024
9 checks passed
@MickStanciu MickStanciu deleted the DEVP-3487-rollback branch September 16, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants