Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-3701] Bump crux gen version 1.35.0 #169

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

junggyu-sc
Copy link
Contributor

Summary

Bump crux gen version 1.35.0. The new version has removed legacy generated API code from protobuf.
https://github.com/SafetyCulture/s12-proto/releases/tag/v1.35.0

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@junggyu-sc junggyu-sc merged commit c5a7964 into main Nov 7, 2024
9 checks passed
@junggyu-sc junggyu-sc deleted the MOB-3701-delete-legacy-proto-generator branch November 7, 2024 03:59
@junggyu-sc junggyu-sc changed the title [MOB-3741] Bump crux gen version 1.35.0 [MOB-3701] Bump crux gen version 1.35.0 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants