Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-3320] Update RocksDB 8.3.2 #9

Merged
merged 2 commits into from
Aug 1, 2023
Merged

[MOB-3320] Update RocksDB 8.3.2 #9

merged 2 commits into from
Aug 1, 2023

Conversation

junggyu-sc
Copy link

@junggyu-sc junggyu-sc commented Aug 1, 2023

Summary

  • created 8.3.2.sc which is FB RocksDB 8.3.2.
  • I am going to merge 8.3.2.sc-update to 8.3.2.sc.
  • fix build error for iOS : patches from the previous fix
  • fix build error for Android armeabi-v7a: stackoverflow

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@junggyu-sc junggyu-sc changed the title Update RocksDB 8.3.2 [MOB-3320] Update RocksDB 8.3.2 Aug 1, 2023
@junggyu-sc junggyu-sc merged commit cbb5039 into 8.3.2.sc Aug 1, 2023
1 of 3 checks passed
@codingrhythm codingrhythm deleted the 8.3.2.sc-update branch August 1, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants