Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTG-3243 add asset id to feed schedules #457

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

MickStanciu
Copy link
Collaborator

Summary

Add asset_id to the feed schedules

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@MickStanciu MickStanciu self-assigned this Feb 13, 2024
@MickStanciu MickStanciu requested a review from a team as a code owner February 13, 2024 23:14
HarryTranAU
HarryTranAU previously approved these changes Feb 14, 2024
@MickStanciu MickStanciu merged commit d541dee into main Feb 14, 2024
14 checks passed
@MickStanciu MickStanciu deleted the INTG-3243-asset-id-for-schedules branch February 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants