Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTG-3307 - adding note to schedule occurence feed. #470

Merged
merged 2 commits into from
Jun 12, 2024
Merged

INTG-3307 - adding note to schedule occurence feed. #470

merged 2 commits into from
Jun 12, 2024

Conversation

sc-gv
Copy link
Contributor

@sc-gv sc-gv commented Jun 12, 2024

Summary

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@sc-gv sc-gv requested a review from a team as a code owner June 12, 2024 01:56
@sc-gv sc-gv merged commit 350ee8a into main Jun 12, 2024
13 of 14 checks passed
@sc-gv sc-gv deleted the INTG-3307 branch June 12, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarryMacchicken BarryMacchicken BarryMacchicken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-gv @BarryMacchicken