WORKFLOWS-25: support sceptre resolvers in build #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthyer
force-pushed
the
workflows-25_resolvers
branch
from
bf1003e to
28b6f43
Compare
|
@daisyhan97 Here's another PR that may interest you |
zaro0508
approved these changes
Jul 1, 2021
| @@ -4,10 +4,11 @@ verify_ssl = true | |||
| name = "pypi" | |||
|
|
|||
| [packages] | |||
| sceptre = "2.4.0" | |||
| sceptre = "2.5.0" | |||
There was a problem hiding this comment.
shouldn't these be in dev-packages?
There was a problem hiding this comment.
It could be in dev, but then the only contents of the Pipfile would be in dev.
.github/workflows/aws-deploy.yaml
Outdated
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install pipenv | ||
| pipenv install |
There was a problem hiding this comment.
shouldn't this be pipenv install --dev?
tthyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current github actions workflow uses a sceptre action which does not support custom resolvers. This is limits how we have come to use sceptre -- for example, we won't be able to use the ever-popular
sceptre-ssm-resolver. I have use cases for usingsceptre-cmd-resolver, so I have refactored the workflow to use the pipenv environment instead and forgo the sceptre action.I also want to make more of a case for using pipenv in this way. It makes sense that you set up your dependencies file -- whether that is
requirements.txtorPipfile-- that can be used in any environment. In other words, it creates an environment that I can use to build whether I am developing or the build action is running on github. When we use the sceptre custom action, we're effectively departing from the simplicity of a single build environment.This solves blocking issue WORKFLOWS-25.