Deploy to production #192
Merged
Deploy to production #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update pre-commit linter versions * Add a linter to validate GH action config files
Update pre-commit linters
…-new-recipients Parameterize `notifications_email` for budgets
thomasyu888
approved these changes
May 4, 2023
There was a problem hiding this comment.
✔️ LGTM!
View this thread/Jira ticket linked: https://sagebionetworks.slack.com/archives/CEFQD0KU1/p1681397761840869?thread_ts=1681397761.840869&cid=CEFQD0KU1. I had a similar thought as yours, but I didn't push harder on it. Perhaps we can revisit at a later date.
|
Yeah, let's try this method for now. |
|
As described in issue IT-2790, creating this PR is an optional step. You also have the option to just directly push these merges to prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what we should write in the description of these PRs. Maybe we should deploy to prod with versioned releases instead of merges into main. This way, we can generate changelogs automatically using GitHub. Just an idea.