[WORKFLOWS-62 | WORKFLOWS-76] Add CostCenter tags
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoGrandePhD
changed the title
SageFinanceProgramCode tags everywhereSageFinanceProgramCode tags
|
@brucehoff: I can't request a review from you yet since you're not a member of this GitHub organization (invite sent), but I'm tagging you in case you're interested. |
thomasyu888
approved these changes
Nov 18, 2021
tthyer
approved these changes
Nov 18, 2021
…assign-program-codes
zaro0508
approved these changes
Nov 18, 2021
BrunoGrandePhD
changed the title
SageFinanceProgramCode tagsCostCenter tags
brucehoff
reviewed
Nov 22, 2021
There was a problem hiding this comment.
The outstanding issue is that if the list of CostCenters defined by Sage changes then the tags added here will be wrong. I would like to see a central list of CostCenters (that Sage can maintain) and a mechanism (like a Service Control Policy) to make sure that tags added to resources here conform to that list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes after a discussion with IT on how we can best implement tagging in a way that's more useful for Finance. For more context, I suggest you read through WORKFLOWS-76 and IT-796. I believe these AWS accounts will be the first to implement this approach, so I'm all ears for feedback.
You can skip to this point in the "Files changes" tab to see examples of program codes being used (everything else is just using a template variable).
I'm also tackling WORKFLOWS-62 to reduce repetition of our default stack tags.