Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate important info to Confluence wiki page with watchers #78

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

BrunoGrandePhD
Copy link
Contributor

In this PR, I propose using a Confluence wiki page to disseminate important information. I was initially going to create a Google Group, but I like how diffs are emailed to watchers on Confluence. Edits can optionally be published without notifying users in case we need to add less critical information.

An added benefit of this approach is that we don't have to trigger our CI workflow with frequent edits to the README.

Here's the Confluence page: https://sagebionetworks.jira.com/l/c/1hm4NP7a. Only Tess, Tom, and I have edit-access at the moment. Let me know if there's any important information that should be added.

@BrunoGrandePhD BrunoGrandePhD requested a review from a team as a code owner November 18, 2021 16:40
Copy link
Contributor

@tthyer tthyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of moving anything that is Sage-related to Confluence. nextflow-infra could still be used by people outside Sage, so ideally the README would be for that audience.

Regarding trigger builds with README edits, there's a way to skip builds for those edits:

on:
  push:
    paths-ignore:
      - README.md

@BrunoGrandePhD
Copy link
Contributor Author

@tthyer: I should have known that there was a way to exclude files from the CI trigger. I added an exclusion for Markdown files. The updates to the important information are intended for Sage staff on how to use our internal Tower instance. The mechanics of our repository can remain documented in README/CONTRIBUTING (at least until we set up a library repository).

@BrunoGrandePhD BrunoGrandePhD merged commit eae0403 into main Nov 18, 2021
@BrunoGrandePhD BrunoGrandePhD deleted the bgrande/WORKFLOWS-26/important-info branch November 18, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants