[ORCA-175] Adds SuiteStatus #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story ORCA-175 · As an output, return the input manifest but with dcqc_status column for ease of use |
BWMac
changed the title
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 22 +1
Lines 1044 1090 +46
Branches 170 178 +8
=========================================
+ Hits 1044 1090 +46
|
thomasyu888
approved these changes
Jun 9, 2023
BrunoGrandePhD
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first half of the
py-dcqcchanges needed to accomplish ORCA-175 (second half added in #39). It adds the enumSuiteStatus, and makes changes toSuiteABCto apply this status based on the results of all of the component tests in a suite. It also updates The tests and example files needed to run those tests for the new changes. The newSuiteStatusstatuses include:NONE- status has yet to be evaluatedGREEN- All tests required or otherwise either passed or were skippedRED- At least one required test failedAMBER- All required tests either passed or were skipped AND at least one non-required test failedThe application of this status has been tested in
nf-dcqcand behaves as expected.