Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etl-84/s3tojson tweaks #26

Merged
merged 10 commits into from
Dec 3, 2021
Merged

Etl-84/s3tojson tweaks #26

merged 10 commits into from
Dec 3, 2021

Conversation

tthyer
Copy link
Contributor

@tthyer tthyer commented Dec 3, 2021

  • What was the glue-job template becomes the glue-spark-job template, and there's a new glue-python-job template too: the first is for glueetl jobs (i.e. spark) and the 2nd is for pythonshell. These take different options, or more accurately, the latter takes a small subset of the former's possible options.
  • s3_to_json_s3.py logging changed to python logging instead of spark logging
  • Replaced old test data with updated data (more about this in the next PR that deals with ETL-83)
  • Made the S3ToJson job able to handle multiple records (more groundwork for later) and had to extend its timeout to handle that

@tthyer tthyer temporarily deployed to develop December 3, 2021 02:48 Inactive
@tthyer tthyer marked this pull request as ready for review December 3, 2021 02:56
@thomasyu888
Copy link
Member

Lgtm except for the failing deployment

@tthyer tthyer temporarily deployed to develop December 3, 2021 18:33 Inactive
@tthyer
Copy link
Contributor Author

tthyer commented Dec 3, 2021

That failing deployment has happened a couple of times when github action runs sam build. Always fails with error Error: SnsToGlueFunction failed to build: toomanyrequests: Rate exceeded on the ECR pull. Going to try a docker login step to ECR to fix this b/c authenticated pulls have a diff rate limit than unauthenticated, and our github workflow must be using a shared IP, which would be the identity from ECR's p.o.v., so it's not too surprising that I would see this error periodically.

@tthyer tthyer temporarily deployed to develop December 3, 2021 19:22 Inactive
@tthyer tthyer temporarily deployed to develop December 3, 2021 20:28 Inactive
@tthyer tthyer merged commit 8fd7c37 into main Dec 3, 2021
@tthyer tthyer deleted the ETL-84/s3tojson-tweaks branch December 3, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants