-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Etl-84/s3tojson tweaks #26
Conversation
tthyer
commented
Dec 3, 2021
•
edited
Loading
edited
- What was the glue-job template becomes the glue-spark-job template, and there's a new glue-python-job template too: the first is for glueetl jobs (i.e. spark) and the 2nd is for pythonshell. These take different options, or more accurately, the latter takes a small subset of the former's possible options.
- s3_to_json_s3.py logging changed to python logging instead of spark logging
- Replaced old test data with updated data (more about this in the next PR that deals with ETL-83)
- Made the S3ToJson job able to handle multiple records (more groundwork for later) and had to extend its timeout to handle that
Lgtm except for the failing deployment |
That failing deployment has happened a couple of times when github action runs |