Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct ref name from the delete event when cleaning up #56

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Use the correct ref name from the delete event when cleaning up #56

merged 1 commit into from
Mar 4, 2022

Conversation

tthyer
Copy link
Contributor

@tthyer tthyer commented Mar 4, 2022

The problem with the cleanup.yaml has been that the ref_name field of the DELETE event's payload is not the name of the branch being deleted -- it is main. To get the name of the branch being deleted, use event.ref.

@tthyer tthyer requested a review from a team as a code owner March 4, 2022 00:08
@tthyer tthyer temporarily deployed to develop March 4, 2022 00:09 Inactive
@tthyer tthyer merged commit 38bb39d into main Mar 4, 2022
@tthyer tthyer deleted the ETL-121-change-payload-data-used branch March 4, 2022 00:14
thomasyu888
thomasyu888 reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthyer @thomasyu888