[ETL-33] CFN stacks: revise bucket, add role, database, classifier #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put in dev environment
tthyer
commented
Sep 20, 2021
| parameters: | ||
| DatabaseName: bridge-downstream-etl | ||
| stack_tags: | ||
| {{ stack_group_config.default_stack_tags }} |
There was a problem hiding this comment.
I anticipate that this will eventually not be a free-standing stack, but will rather be part of a nested stack created per-study.
tthyer
commented
Sep 20, 2021
| @@ -76,7 +76,7 @@ Resources: | |||
| - Sid: ReadAccess | |||
| Effect: Allow | |||
| Principal: | |||
| AWS: !Ref ReadWriteAccessArns | |||
| AWS: !Ref ReadOnlyAccessArns | |||
There was a problem hiding this comment.
this was a mistake in the previous PR
thomasyu888
approved these changes
Sep 21, 2021
templates/glue-database.yaml
Outdated
| @@ -0,0 +1,15 @@ | |||
| AWSTemplateFormatVersion: '2010-09-09' | |||
| Description: TBD | |||
There was a problem hiding this comment.
Nit: Fill in description later?
There was a problem hiding this comment.
thanks -- pushed a description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next installment for ETL-33.
srcdirectory, which does have subfolders underneath it. I moved diagrams to a docs directory.