Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #215

Merged
merged 122 commits into from
Mar 6, 2021
Merged

Release 4.0.0 #215

merged 122 commits into from
Mar 6, 2021

Conversation

thomasyu888
Copy link
Member

  • Fixes #xxxx (Link the github issue if applicable)
  • Did you run your tests locally (instructions here)?
  • Did you add a good description about your changes or additions?
  • Support Python 3.9
  • Require Synapse Python Client >= 2.3.0
  • Deprecate helpers.py
  • Fix conditionals for permissions check

thomasyu888 and others added 30 commits March 1, 2020 22:03
@thomasyu888
Use dataclass
075fc75
@thomasyu888
add uri into challenge class
acf6524
@thomasyu888
Use dataclass and dataclass json
2b79577
@thomasyu888
Add challenge service
dbecb32
@thomasyu888
Fix
2a1e5ed
@thomasyu888
Add in dataclasses req
2bac2d9
@thomasyu888
Add in requirement
e1e6a25
@thomasyu888
Use specific version
2665e04
@thomasyu888
Fix tests
c128520
@thomasyu888
Merge branch 'develop' into challenge-dataclass
e8cc34d
@thomasyu888
Remove last line
d3aa147
@thomasyu888
Revise challenge data obj + add challengeApi
6ad0de6
@thomasyu888
Add tests
746ce88
@thomasyu888
Merge branch 'develop' into challenge-dataclass
ec71d4c
@thomasyu888
Add tests for challenge service
5a7d8db
@thomasyu888
Merge branch 'challenge-dataclass' of https://github.com/Sage-Bionetw…
ab2ec0e 
…orks/challengeutils into challenge-dataclass
@thomasyu888
test rest calls
1ad71ef
@thomasyu888
Move synapse services to within challengeutils folder
ce0f77e
@thomasyu888
Fix tests
92ca97e
@thomasyu888
Fix tests
4d18021
@thomasyu888
Fix functions
8845fe9
@thomasyu888
Rename
a92218c
@thomasyu888
Switch to challenge instead of util
53c3e09
@thomasyu888
Fix tests and finish up refactor
2c0ecb9
@thomasyu888
Remove duplicate
885fe57
@thomasyu888
Remove unused var
5fe87cf
@thomasyu888
Push dev version
3fb14a1
@thomasyu888
Merge branch 'master' into develop
c2d751d
@thomasyu888
Fix
a78d3c0
@thomasyu888
Merge branch 'develop' into challenge-dataclass
06d9888
thomasyu888 and others added 15 commits October 28, 2020 21:20
@thomasyu888
update synapse to at least v2.2.0 (#200)
d543371
@thomasyu888
Update challengeutils/__version__.py
12522eb
@thomasyu888
Get team member count rest call (#201)
72e7aed 
* Get team member count rest call

* Add tests

* Add tests

* Update tests/test_teams.py
@thomasyu888
Update challengeutils/__version__.py
1643e4b
@thomasyu888
Move to team module (#202)
b6740a9 
* move team related functions to team module

* ilnt
@thomasyu888
Merge branch 'master' into develop
3faab17
@thomasyu888
Pull and push synapse wikis in markdown + wiki config (#133)
53a2af8 
* Create functions to - download and upload synapse wikis in markdown + wiki config

* Add doc strings

* Add cli

* add more details in print

* Change to pull and push wiki, remove config_path and use workdir

* Add docs

* Add docs

* Add docs

* Edit

* Edit docs

* Use workdir parameter for all wiki commands

* Add docs

* add doc

* Add tests

* Add tests

* Lint

* Make improvements

* Add fine grain validationg

* Lint

* Test for strings and ints

* Fix tests

* Remove

* Edit

* Comment out valiate-wiki-config function

* Fix

* Make sure to use isfile instead of os.path.exists

* Edit

* Add wikiId in front of markdown path

* Add comment

* Update wiki
@thomasyu888
Update docs/client/source.rst
5d0b184
@thomasyu888
Bump version
a3e76f0
@thomasyu888
Update challengeutils/__main__.py
0493ba3
@vpchung
fix conditionals for permissions
66e10c0
@thomasyu888
Fix merge conflicts
e626398
@thomasyu888
Merge branch 'develop' into writeup-fix
ee0f174
@vpchung
Merge pull request #212 from Sage-Bionetworks/writeup-fix
6b49c30 
fix conditionals for permissions check
@thomasyu888
Add release
5f4c3f6
@coveralls
Copy link

coveralls commented Mar 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 626999877

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.3%) to 81.544%
Totals Coverage Status
Change from base Build 530072008: 3.3%
Covered Lines: 1056
Relevant Lines: 1295
💛 - Coveralls

@pep8speaks
Copy link

pep8speaks commented Mar 4, 2021 •
edited
Loading

Hello @thomasyu888! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 21:80: E501 line too long (94 > 79 characters)
Line 22:80: E501 line too long (84 > 79 characters)
Line 23:80: E501 line too long (81 > 79 characters)
Line 328:5: E125 continuation line with same indent as next logical line

Line 36:80: E501 line too long (83 > 79 characters)

Comment last updated at 2021-03-06 12:48:31 UTC

@thomasyu888
Update syn client (#214)
3bad898 
* Update client

* Remove support for 3.6

* Limit

* Remove version for pandas

* Fix

* Don't drop support for python 3.6 yet

* Don't set pandas version
@thomasyu888
Deprecate helpers (#213)
f3bd88b 
* Remove helpers, but refactor stopping submissions that are over a specific quota

* Remove tests for helpers

* Add in tests

* Add submission tests

* query fail
@thomasyu888
Fix merge conflicts
b7be712
@thomasyu888 thomasyu888 marked this pull request as ready for review March 6, 2021 09:59
thomasyu888
thomasyu888 commented Mar 6, 2021
View reviewed changes
thomasyu888
thomasyu888 commented Mar 6, 2021
View reviewed changes
thomasyu888
thomasyu888 commented Mar 6, 2021
View reviewed changes
@thomasyu888 thomasyu888 merged commit 663a389 into master Mar 6, 2021
@thomasyu888 thomasyu888 deleted the release-4.0.0 branch March 6, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasyu888 @coveralls @pep8speaks @vpchung