Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1240] Add grs toggle #162

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[GEN-1240] Add grs toggle #162

wants to merge 2 commits into from

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented Nov 11, 2024

Purpose: This PR is a draft PR. Majority of the code design is present. At times we would like to use the data dictionary (dd) as the primary mapping for a dataset over the combined mapping of dd and global response set (grs) for particular cohorts. This PR adds the ability to specify a use_grs parameter for whether we should use grs or not for the cohort.

This is specific only to the merge_and_decode step. This is the 1st PR in a series. See 2nd PR in series

Changes:

  • Added production and use_grs parameters and logic to support that
  • Added helper functions get_global_response_set and get_prov_used for easier testability and incorporation of the use_grs param

Testing:

  • Unit tests (still in progress)
  • Run merge_and_decode step with use_grs on staging and compare to production run in develop (should be the same result)
  • Run merge_and_decodestep **without**use_grs` and compare to production run in develop (should have mapping differences)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant