[ETL-628] Rework S3 event config lambda #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
reviewed
Mar 4, 2024
BryanFauble
reviewed
Mar 4, 2024
BryanFauble
reviewed
Mar 4, 2024
BryanFauble
approved these changes
Mar 4, 2024
There is a bug in moto/AWS where moto only allows filter rules with lowercase `Name` values in put_bucket_notification_configuration calls. So to normalize our notification configurations when comparing configurations obtained via a GET with configurations to be utilized in a PUT (as we do in the function `notification_configuration_matches`), we make the `Name` values lower case in when comparing notification configurations. When calling get_bucket_notification_configuration, the `Name` value is always capitalized, whereas moto requires us to use lowercase `Name` values when calling put_bucket_notification_configuration.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant changes in the S3 event config lambda to support indexing individual configurations based on their S3 prefix/suffix overlap.
.github/workflows/upload-and-deploy-to-prod-main.yamland.github/workflows/upload-and-deploy.yamlsrc/lambda_function/s3_event_config/app.pyNotificationConfiguration: creates a common interface for interacting with individual notification configurations.NotificationConfigurationType: subsets the Enum class to restrict the types allowed for aNotificationConfigurationtoQueue,Topic, andLambdaFunction.BucketNotificationConfigurations: A convenience class which wraps a collection ofNotificationConfigurationobjects and provides a method for converting them back into a dict representation which can be used withput_bucket_notification_configuration.add_notificationis now more strict. Notification configurations can be added, but not updated. See the docstring for more details.delete_notificationnow uses the prefix filter rules to identify which notification needs deletion.