Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-659] Enable any branch to be deployed to any environment #127

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

philerooski
Copy link
Contributor

When merging a PR into main, we deploy changes to a staging Snowflake environment. Because we can only do variable substitution in a stage path using CLI variables when invoking our entrypoint snowflake/objects/deploy.sql from the command line, I've split the environment variable into an environment and git_branch variable. Both must be specified.

@philerooski philerooski requested a review from a team as a code owner July 15, 2024 22:48
Copy link

Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! It's awesome seeing this all come together.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@philerooski philerooski merged commit 170decb into main Jul 16, 2024
18 checks passed
@philerooski philerooski deleted the etl-659-fix branch July 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants