[ETL-673] Upload compressed JSON as part of S3 to JSON #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a bug where I was uploading the files before closing their file objects, but I believe that's resolved now. |
thomasyu888
reviewed
Aug 20, 2024
| current_output_path = output_path | ||
| line_count = 0 | ||
| # fmt: off | ||
| # <python3.10 requires this backslash syntax, we currently run 3.7 |
There was a problem hiding this comment.
Thanks, we do have a ticket to update to python 3.10, do you think we should do that sooner than later?
There was a problem hiding this comment.
No, we may end up abandoning Glue altogether so it doesn't make sense spending time upgrading python just to avoid these minor inconveniences.
thomasyu888
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to partitioning and writing JSON to JSON datasets as "part files", e.g.,
Write the JSON as a gzip archive to a separate
compressed_jsonS3 prefix.This PR is meant to ease the transition towards exclusively using compressed JSON data as the input to JSON to Parquet. Hence, there are a few changes here which are meant to be refactored later on once we remove the logic for writing uncompressed part files. The primary changes are to the function
write_file_to_json_datasetwith some supporting changes in helper functions.You can get a more concrete feel for how this affects the behavior of S3 to JSON by examining the result of the integration tests in
s3://recover-dev-intermediate-data/etl-673/.