Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-694] Specify python-version in actions/setup-python #148

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

philerooski
Copy link
Contributor

Fixes bug described in ticket.

@philerooski philerooski requested a review from a team as a code owner October 14, 2024 22:25
@philerooski
Copy link
Contributor Author

There appears to be another bug with the Snowflake action we are using, as described here: Snowflake-Labs/snowflake-cli-action#28

I think this will be resolved by Snowflake-Labs within the next few days so let's wait on them, rather than specifying a specific version of the action, which would need to be reverted later.

@thomasyu888
Copy link
Member

There appears to be another bug with the Snowflake action we are using, as described here: Snowflake-Labs/snowflake-cli-action#28

I think this will be resolved by Snowflake-Labs within the next few days so let's wait on them, rather than specifying a specific version of the action, which would need to be reverted later.

Lets wait a week to see if it gets resolved by snowflake labs. If not we don't want it to block our work - will the GX work be able to be resumed?

@philerooski
Copy link
Contributor Author

@thomasyu888 Actually -- I'm a little confused by that Snowflake-Labs issue. We should already use v1.5 automatically, since it is the latest minor version of v1. I don't know why another person in that issue says they were able to work around the issue by specifying v1.5 explicitly. I'll have to test this out.

@philerooski
Copy link
Contributor Author

@thomasyu888

will the GX work be able to be resumed?

Technically this is not a blocker, since we aren't making any changes to Snowflake we don't need to worry about breaking anything Snowflake related. We can merge regardless.

But if we wait a few days to see how this plays out, we can see all the green check marks before merging without impeding any dev work, since the GX work is not related to Snowflake, either.

Copy link

sonarcloud bot commented Oct 15, 2024

@philerooski
Copy link
Contributor Author

Snowflake-Labs used an unfortunate tag v1 for their initial tag, rather than v1.0. This caused @v1 to point to a specific tag, rather than use the latest minor version of 1.x. The fix at this point seems to be to specify a specific tag, @v1.5, unless Snowflake-Labs fixes the v1 tag, but it's not clear when they might do so.

@thomasyu888
Copy link
Member

Snowflake-Labs used an unfortunate tag v1 for their initial tag, rather than v1.0. This caused @v1 to point to a specific tag, rather than use the latest minor version of 1.x. The fix at this point seems to be to specify a specific tag, @v1.5, unless Snowflake-Labs fixes the v1 tag, but it's not clear when they might do so.

Make sense - unfortunate... Agree that lets move forward with V1.5 tag

@philerooski
Copy link
Contributor Author

@thomasyu888 Can I get an approving review? Sorry for the formality.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@philerooski philerooski merged commit c1a4ac6 into main Oct 15, 2024
18 checks passed
@philerooski philerooski deleted the etl-694 branch October 15, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants