-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETL-694] Specify python-version in actions/setup-python #148
Conversation
There appears to be another bug with the Snowflake action we are using, as described here: Snowflake-Labs/snowflake-cli-action#28 I think this will be resolved by Snowflake-Labs within the next few days so let's wait on them, rather than specifying a specific version of the action, which would need to be reverted later. |
Lets wait a week to see if it gets resolved by snowflake labs. If not we don't want it to block our work - will the GX work be able to be resumed? |
@thomasyu888 Actually -- I'm a little confused by that Snowflake-Labs issue. We should already use v1.5 automatically, since it is the latest minor version of v1. I don't know why another person in that issue says they were able to work around the issue by specifying v1.5 explicitly. I'll have to test this out. |
Technically this is not a blocker, since we aren't making any changes to Snowflake we don't need to worry about breaking anything Snowflake related. We can merge regardless. But if we wait a few days to see how this plays out, we can see all the green check marks before merging without impeding any dev work, since the GX work is not related to Snowflake, either. |
Quality Gate passedIssues Measures |
Snowflake-Labs used an unfortunate tag |
Make sense - unfortunate... Agree that lets move forward with V1.5 tag |
@thomasyu888 Can I get an approving review? Sorry for the formality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
Fixes bug described in ticket.