Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-380] Add cleanup workflow #28

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[ETL-380] Add cleanup workflow #28

merged 1 commit into from
Mar 29, 2023

Conversation

philerooski
Copy link
Contributor

  • Jobs occur in develop only upon branch deletion
  • Delete namespaced stacks
  • Delete namespaced folder in cloudformation bucket

@philerooski philerooski requested a review from a team as a code owner March 29, 2023 19:05
thomasyu888
thomasyu888 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice - this is going to be great!

@philerooski philerooski merged commit 6807a06 into main Mar 29, 2023
@philerooski philerooski deleted the etl-380 branch March 29, 2023 22:26
@philerooski philerooski restored the etl-380 branch March 29, 2023 22:37
@philerooski philerooski temporarily deployed to develop March 29, 2023 22:37 — with GitHub Actions Inactive
@philerooski philerooski temporarily deployed to develop March 29, 2023 22:38 — with GitHub Actions Inactive
@philerooski
Copy link
Contributor Author

@rxu17 Could you take a look at this? I borrowed lines 16-18 from the upload-and-deploy action, but after merging into main and deleting the feature branch I get this error when the Sage-Bionetworks/action-pipenv-aws-setup@v3 step runs within the cleanup action: "Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers." Although that same step seems to run without issue in the upload-and-deploy action. Did I copy/paste incorrectly?

@philerooski philerooski mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philerooski @thomasyu888