[ETL-395] Modify prod stack configs to use new pre-ETL bucket name #31
Conversation
| input_bucket_name: recover-input-data | ||
| cloudformation_artifact_bucket_name: recover-cloudformation | ||
| intermediate_bucket_name: recover-intermediate-data | ||
| processed_data_bucket_name: recover-processed-data |
There was a problem hiding this comment.
Instead of including the bucket names in the stack group config we should list the bucket stacks as dependencies in the relevant config files and reference the bucket name using
!stack_output_external bucket-stack::BucketName
There was a problem hiding this comment.
Based on our recent slack discussion, and to avoid redundancy in our stack dependencies with the buckets, we will use the stack_group_config way
There was a problem hiding this comment.
You'll also want to use a stack_group_config reference for the BucketName parameter in the bucket stacks themselves: config/prod/s3-cloudformation-bucket.yaml, config/prod/s3-ingestion.yaml, etc.
There was a problem hiding this comment.
Feel free to do the same in dev.
There was a problem hiding this comment.
Yup, I have a ticket that encompasses all of that here: https://sagebionetworks.jira.com/browse/ETL-401
Purpose: We recently created the new pre-ETL (input data) in the prod account, and now the prod stack configs need to be adjusted to use the new bucket. Here a stack group config was also created to house the prod specific bucket names for ease of use across all the prod stacks.