Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-386] Rename pilot data bucket and link to Synapse #32

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[ETL-386] Rename pilot data bucket and link to Synapse #32

merged 1 commit into from
Mar 30, 2023

Conversation

philerooski
Copy link
Contributor

@philerooski philerooski commented Mar 30, 2023 •
edited
Loading

  • Pilot bucket stack renamed to recover-dev-input-bucket and bucket renamed to recover-dev-input-data
  • Synapse permissions granted through use of SynapseIds parameter.

@philerooski philerooski requested a review from a team as a code owner March 30, 2023 21:15
@thomasyu888
Copy link
Member

Thanks @philerooski , can we add a short description in the PR and look into why the CI/CD is failling? Thanks!

@rxu17
Copy link
Contributor

rxu17 commented Mar 30, 2023 •
edited
Loading

I'm thinking this and ETL-396 will have to be combined into one ticket in order for CI/CD to go through? Otherwise, could merge this first and then follow up with ETL-396 which should resolve the CI/CD

Just deleted ETL-396 now that those changes have been migrated to this

@philerooski philerooski temporarily deployed to develop March 30, 2023 21:58 — with GitHub Actions Inactive
@philerooski philerooski temporarily deployed to develop March 30, 2023 21:59 — with GitHub Actions Inactive
rxu17
rxu17 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

thomasyu888
thomasyu888 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@philerooski philerooski merged commit d5b0b4a into main Mar 30, 2023
@philerooski philerooski deleted the etl-386 branch March 30, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu17 rxu17 rxu17 approved these changes

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philerooski @thomasyu888 @rxu17