Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-523] Increase number of workers for types FitbitIntradayCombined and HeathKitV2Samples #72

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[ETL-523] Increase number of workers for types FitbitIntradayCombined and HeathKitV2Samples #72

merged 1 commit into from
Aug 31, 2023

Conversation

philerooski
Copy link
Contributor

No description provided.

@philerooski philerooski requested a review from a team as a code owner August 29, 2023 22:42
@philerooski philerooski temporarily deployed to develop August 29, 2023 22:45 — with GitHub Actions Inactive
@philerooski philerooski temporarily deployed to develop August 29, 2023 22:45 — with GitHub Actions Inactive
@philerooski philerooski temporarily deployed to develop August 29, 2023 22:54 — with GitHub Actions Inactive
@philerooski philerooski temporarily deployed to develop August 29, 2023 22:57 — with GitHub Actions Inactive
rxu17
rxu17 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you think in the future we should start having a config file that contains which data types use which amount of resources, maximum running time, order of data types to runs, etc (I don't know currently how we could pull that info using cloud formation though)

@philerooski
Copy link
Contributor Author

LGTM! Do you think in the future we should start having a config file that contains which data types use which amount of resources, maximum running time, order of data types to runs, etc (I don't know currently how we could pull that info using cloud formation though)

@rxu17 Yes, that's a good solution. We can parse such a file using Jinja. Right now our configuration is simple enough that we can rely on the "dumb" method of having two cloudformation parameters.

thomasyu888
thomasyu888 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 nice!

@philerooski philerooski merged commit 03abdda into main Aug 31, 2023
@philerooski philerooski deleted the etl-523 branch August 31, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu17 rxu17 rxu17 approved these changes

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philerooski @thomasyu888 @rxu17