[ETL-558] Decouple S3 to JSON workflow from JSON to Parquet workflow #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
approved these changes
Oct 12, 2023
thomasyu888
reviewed
Oct 12, 2023
templates/glue-workflow.j2
Outdated
| WorkflowName: !Ref JsonToParquetWorkflow | ||
|
|
||
| JsontoParquetTrigger: | ||
| Condition: !Not IsMainNamespace |
There was a problem hiding this comment.
Weird... it's saying: Every Condition member must be a string.. Is that due to this?
There was a problem hiding this comment.
Based on the error log this might help root out the issue and let us test as changes are made:
aws cloudformation validate-template --template-body templates/glue-workflow.j2
There was a problem hiding this comment.
Yeah. CFN is not very flexible. I fixed it.
There was a problem hiding this comment.
@BryanFauble It seems like that command only checks if the template is valid YAML and not whether it's semantically correct? In any case, I use Jinja in the template so that command fails immediately.
BryanFauble
approved these changes
Oct 13, 2023
philerooski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important changes happen in templates/glue-workflow.j2. This PR splits our workflow into two workflows:
mainnamespace (so as to not waste resources triggering the pipeline every day on our development stacks).