Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-589] Fix parameter type in delete_objects call #98

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[ETL-589] Fix parameter type in delete_objects call #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/glue/jobs/json_to_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ def archive_existing_datasets(
if delete_upon_completion and archived_objects:
deleted_response = s3_client.delete_objects(
Bucket=bucket,
Delete={"Objects": {"Key": obj["Key"] for obj in archived_objects}}
Delete=[obj["Key"] for obj in archived_objects]
)
return archived_objects

Expand Down
2 changes: 1 addition & 1 deletion tests/test_json_to_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ def test_archive_existing_datasets_delete(
)
mock_client.delete_objects.assert_called_once_with(
Bucket=artifact_bucket,
Delete={"Objects": {"Key": obj["Key"] for obj in archived_objects}}
Delete=[obj["Key"] for obj in archived_objects]
)

def test_drop_deleted_healthkit_data(
Expand Down
Loading