Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storybook broken after updating to sb 6+ and angular 12+ #43

Merged
merged 10 commits into from
Aug 19, 2021
Merged

Fix storybook broken after updating to sb 6+ and angular 12+ #43

merged 10 commits into from
Aug 19, 2021

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Aug 19, 2021 •
edited
Loading

Fix #35

Updated storybook packages: npx npm-check-updates '/storybook/' -u && npm install (from here)

@tschaffter tschaffter self-assigned this Aug 19, 2021
@tschaffter tschaffter linked an issue Aug 19, 2021 that may be closed by this pull request
Fix storybook build #35
Closed
@tschaffter tschaffter mentioned this pull request Aug 19, 2021
Merged
@tschaffter
Copy link
Member Author

  • I can build the demo app and it looks great
  • I can build and start storybook, but the components looks like they don't have any styles applied.

@tschaffter
Copy link
Member Author

The issue is likely:

Could not find Angular Material core theme. Most Material components may not work as expected. For more info refer to the theming guide: https://material.angular.io/guide/theming

@tschaffter
Copy link
Member Author

As @literalpie mentioned the global import of a SCSS file stooped working in Storybook 6.3.x with the version 12.2.x of Angular.

Source

@tschaffter tschaffter changed the title Update storybook dependencies Fix storybook broken after updating to sb 6+ and angular 12+ Aug 19, 2021
@tschaffter
Copy link
Member Author

The above issue is now tracked in #48 . For now sticking to Angular 12.1.x avoids the issue.

@tschaffter tschaffter merged commit f696def into develop Aug 19, 2021
@tschaffter tschaffter deleted the fix-storybook branch August 19, 2021 04:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix storybook build
1 participant
@tschaffter