Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openchallenges): restructure docs site #2441

Merged
merged 15 commits into from
Feb 13, 2024

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Jan 23, 2024

Fixes #2430

Changelog

  • Update categories to:
    • Home: overview of the monorepo, current supported tools/products
    • Getting Started: introduces the technologies involved and how to setup locally/remotely
    • Tutorials: walks user through how to develop, organized by product
    • Developers Guide: walks user through how to maintain and update the monorepo
    • Reference: list of classes/APIs/microservices, organized by product

To test locally

  1. Install mkdocs, mkdocs-material, and termynal, ideally in a virtual environment, e.g.

    conda create -n docs python=3.12
    conda activate docs
    pip install mkdocs mkdocs-material termynal
    
  2. Checkout this branch, then start the server:

    mkdocs serve
    

    This will serve the documentation on http://127.0.0.1:8000. If you get an error about the port already being used, stop the affected container:

    workspace-docker-stop
    

Once done, stop the server with Ctrl + C

Preview

More recent screenshots found in comment below

Home page
Screenshot 2024-01-23 at 3 10 49 PM

Getting Started
Screenshot 2024-01-23 at 3 11 01 PM

Tutorials
Screenshot 2024-01-23 at 3 11 07 PM

Developers Guide
Screenshot 2024-01-23 at 3 11 14 PM

Reference
Screenshot 2024-01-23 at 3 11 20 PM

@vpchung vpchung requested a review from tschaffter as a code owner January 23, 2024 23:16
@vpchung vpchung changed the title fix(openchallenges): fix(openchallenges): restructure docs site Jan 23, 2024
@tschaffter
Copy link
Member

Home page:

  • the logos don't render in the markdown preview on GH
  • the logos take a lot of space, including in the source of the file
    • replace by a table that include info about the project and link to the product space on the doc site?
  • Tutorials
    • Split by programming languages or project type
    • This should contribute to developing reusable components instead of project-specific component
      • E.g. Creating a REST API in Python should be the same for Schematic or OpenChallenges
    • Types of projects:
      • Java:
        • library
        • REST API
      • Python
        • REST API
      • Angular
        • App
        • library
        • API client for Angular (is a library)
      • R
        • library
    • Docker-based project (e.g. openchallenges-mariadb)

@tschaffter
Copy link
Member

@vpchung The proposed structure is already a nice improvement on the initial version. Feel free to use my feedback as you see fit and then merge when you are satisfied. I expect the structure of the docs to become clearer as we start curating its content.

@vpchung
Copy link
Member Author

vpchung commented Jan 29, 2024

the logos don't render in the markdown preview on GH

I did not touch the main README for the repo, so no changes should be seen there. Nevermind, I misunderstood what you meant here.

replace by a table that include info about the project and link to the product space on the doc site?

Split by programming languages or project type

Sounds good.

@vpchung
Copy link
Member Author

vpchung commented Feb 1, 2024

Feedback has been implemented:

Screenshot 2024-02-01 at 2 26 40 PM

Screenshot 2024-02-01 at 2 26 52 PM

@vpchung vpchung added the sonar-scan-approved-deprecated Ready for Sonar code analysis label Feb 1, 2024
@vpchung vpchung self-assigned this Feb 1, 2024
@vpchung
Copy link
Member Author

vpchung commented Feb 1, 2024

then merge when you are satisfied

@tschaffter I don't have the permission to force-merge without an approval. We can merge this after your return!

@tschaffter
Copy link
Member

@vpchung How can this PR be tested?

@vpchung
Copy link
Member Author

vpchung commented Feb 5, 2024

Thanks, added notes above to the description.

@vpchung vpchung merged commit 6343bd6 into Sage-Bionetworks:main Feb 13, 2024
15 of 16 checks passed
@vpchung vpchung deleted the docs-2430 branch February 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Structure Sage Monorepo docs
2 participants