Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push devcontainer to new Docker Hub repository #254

Merged
merged 8 commits into from
Jun 2, 2022

Conversation

tschaffter
Copy link
Member

Configure VS Code devcontainer to use the new image ghcr.io/sage-bionetworks/challenge-devcontainer:latest.

@tschaffter tschaffter self-assigned this May 31, 2022
@tschaffter
Copy link
Member Author

@zaro0508 @xschildw I would like to set the visibility of the Docker image ghcr.io/sage-bionetworks/challenge-devcontainer created by this repo to Public. However, I don't have the required permission to change the visibility of this image:

image

The definition of this image lives here.

Until now we pushed this image to Docker Hub but I wanted to give a try to ghcr.io for the first time.

I have a few questions:

  • Does Sage supports / promotes using ghcr.io?
  • If yes, can you please change the visibility of this image to Public? This will make the development workflow used by our team smoother.

@tschaffter tschaffter marked this pull request as draft May 31, 2022 00:24
@tschaffter
Copy link
Member Author

From the Confluence page Building Container Images:

GitHub Container Registry (ghcr)

Building a container and pushing it to ghcr requires a service account within the GitHub organization. This service account must be an owner of the organization. When a container repository is first created on ghcr it is private. To make it public, you must log in with the service account and manually make the package visibility public.

The credentials for this service account are kept in LastPass and are made available only to other owners of the organization because the service account has excessive permissions.

Hosting the image on ghcr is accepted at Sage according to the doc.

@zaro0508 @xschildw Could one of you make the above ghcr image publicly available?

@tschaffter tschaffter changed the title Use devcontainer hosted on ghcr Push devcontainer to new Docker Hub repository Jun 1, 2022
@tschaffter
Copy link
Member Author

EDIT: After thinking about it, it's easier for our team to continue using Docker Hub instead of ghcr because I already have the required permission to push to Docker Hub.

@tschaffter
Copy link
Member Author

Giving it a try!

@tschaffter tschaffter marked this pull request as ready for review June 2, 2022 14:36
@tschaffter tschaffter merged commit a58cd26 into Sage-Bionetworks:main Jun 2, 2022
@tschaffter tschaffter deleted the use-new-devcontainer branch June 2, 2022 14:36
tschaffter pushed a commit to tschaffter/sage-monorepo that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant