Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sage-monorepo): migrate to Nx v18 and Angular v17 #2591

Merged
merged 1 commit into from
Mar 22, 2024
Merged

chore(sage-monorepo): migrate to Nx v18 and Angular v17 #2591

merged 1 commit into from
Mar 22, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Mar 22, 2024 •
edited
Loading

Closes #2582
Closes #2583

Changelog

  • run the Nx and Angular migration tool provided by Nx
  • convert a single instance of MatLegacyButton removed from Angular v17
  • comment out the eslint rule @nx/enforce-module-boundaries until a solution is found
  • remove example Angular app and lib for Agora
  • remove the task lint for the project openchallenges-api-client-angular

Note

  • ⚠️ Nx migration tool remove code commented out in project.json files
  • Angular v17 changes how server-side bundles are generated (should now be using the same tool as client side)
    • The migration tool generated a new server file that was relatively straightforward to customize for OC needs.

@tschaffter tschaffter self-assigned this Mar 22, 2024
@tschaffter tschaffter added the sonar-scan-approved-deprecated Ready for Sonar code analysis label Mar 22, 2024
@tschaffter tschaffter marked this pull request as ready for review March 22, 2024 19:57
rrchai
rrchai approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@rrchai rrchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM!

@tschaffter tschaffter merged commit a1c076d into Sage-Bionetworks:main Mar 22, 2024
15 of 16 checks passed
@tschaffter tschaffter deleted the update-nx-take-2 branch March 22, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrchai rrchai rrchai approved these changes

@andrewelamb andrewelamb Awaiting requested review from andrewelamb

@GiaJordan GiaJordan Awaiting requested review from GiaJordan

@linglp linglp Awaiting requested review from linglp

@mialy-defelice mialy-defelice Awaiting requested review from mialy-defelice

@milen-sage milen-sage Awaiting requested review from milen-sage

@mdsage1 mdsage1 Awaiting requested review from mdsage1

@vpchung vpchung Awaiting requested review from vpchung

Assignees

@tschaffter tschaffter

Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update Angular from v16 to v17 update Nx
2 participants
@tschaffter @rrchai